Fix feature gate visitor #3136
Merged
Fix feature gate visitor #3136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CohenArthur
force-pushed
the
fix-feature-gate-visitor
branch
from
39809b9 to
ce65813
Compare
P-E-P
approved these changes
Aug 22, 2024
| { | ||
| switch (name) | ||
| switch (f) | ||
| { | ||
| case Feature::Name::ASSOCIATED_TYPE_BOUNDS: | ||
| return Feature (Feature::Name::ASSOCIATED_TYPE_BOUNDS, | ||
| Feature::State::ACCEPTED, "associated_type_bounds", |
There was a problem hiding this comment.
Should we introduce constexpr for those feature name ? Probably not because most of the code will make use of the features, not their name.
CohenArthur
force-pushed
the
fix-feature-gate-visitor
branch
2 times, most recently
from
77e0aa2 to
e2562fd
Compare
This commit turns a few of the fields into `tl::optional<T>` and cleanups the constructor with a couple default parameters. We can also reuse the variable that we are `switch`ing on, instead of repeating the enum variants each time. Most importantly, the `FeatureGate` visitor now uses the `DefaultAstVisitor` correctly, and will now visit nested items. This means that we have to fix a bunch of the testsuite as some feature attributes were missing. gcc/rust/ChangeLog: * checks/errors/rust-feature.cc (Feature::create): Reuse variable, remove now optional parameters from constructor. * checks/errors/rust-feature.h: Cleanup class definition. * checks/errors/rust-feature-gate.cc (FeatureGate::gate): Use optional. * checks/errors/rust-feature-gate.h: Cleanup visitor implementation. gcc/testsuite/ChangeLog: * rust/compile/assume.rs: Add missing feature attribute. * rust/compile/issue-1901.rs: Likewise. * rust/compile/issue-1981.rs: Likewise. * rust/compile/sizeof-stray-infer-var-bug.rs: Likewise. * rust/compile/torture/intrinsics-8.rs: Likewise. * rust/compile/torture/transmute-size-check-1.rs: Likewise. * rust/compile/torture/transmute1.rs: Likewise. * rust/compile/torture/uninit-intrinsic-1.rs: Likewise. * rust/execute/torture/issue-1436.rs: Likewise. * rust/execute/torture/issue-2583.rs: Likewise.
CohenArthur
force-pushed
the
fix-feature-gate-visitor
branch
from
e2562fd to
00879ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #3135, so only review the last commit
This commit turns a few of the fields into
tl::optional<T>and cleanupsthe constructor with a couple default parameters. We can also reuse the
variable that we are
switching on, instead of repeating the enum variantseach time.
Most importantly, the
FeatureGatevisitor now uses theDefaultAstVisitorcorrectly, and will now visit nested items. This means that we have to
fix a bunch of the testsuite as some feature attributes were missing.