Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add virtual destructor to AbstractExpr #3147

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Add virtual destructor to AbstractExpr #3147

merged 1 commit into from
Sep 6, 2024

Conversation

powerboat9
Copy link
Contributor

This allows std::unique_ptr<AbstractExpr> to be properly destructed, discovered during development of #3142.

@powerboat9
Add virtual destructor to AbstractExpr
b7be06f 
gcc/rust/ChangeLog:

	* checks/errors/borrowck/rust-bir.h
	(class AbstractExpr): Add virtual destructor.

Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
P-E-P
P-E-P approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@P-E-P P-E-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stumbled upon the same warning, thank you!

@P-E-P P-E-P added this pull request to the merge queue Sep 6, 2024
Merged via the queue into Rust-GCC:master with commit 84f772c Sep 6, 2024
11 checks passed
@powerboat9 powerboat9 deleted the add-virt-dest branch September 6, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-E-P P-E-P P-E-P approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@powerboat9 @P-E-P