refactor all attribute functions in rust-privacy-reporter.cc #3339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* checks/errors/privacy/rust-privacy-reporter.cc (find_proc_macro_attribute):"Removed checker function" (proc_macro_privacy_check): "modified checker implementation" * util/rust-attributes.cc (is_proc_macro_type): "modifed fn into Attributes class" (Attributes::is_proc_macro_type): "modifed fn" (check_proc_macro_non_function): "modified checker implementation" (check_proc_macro_non_root): "modified checker implementation" * util/rust-attributes.h: "included definition" Signed-off-by: Om Swaroop Nayak <96killerat96@gmail.com>
|
You need to fix your commit format before this can be merged |
philberty
requested changes
Jan 10, 2025
| // attribute in a vector of attribute | ||
| for (const auto &attr : item->get_outer_attrs ()) | ||
| { | ||
| if (Analysis::Attributes::is_proc_macro_type (attr) != tl::nullopt) |
There was a problem hiding this comment.
this seems odd i think you should be storing the result here in a variable instead of calling it twice like this
| // Emit an error when one encountered attribute is either #[proc_macro], | ||
| // #[proc_macro_attribute] or #[proc_macro_derive] | ||
| static void | ||
| check_proc_macro_non_function (const AST::AttrVec &attributes) | ||
| { | ||
| for (auto &attr : attributes) | ||
| { | ||
| if (is_proc_macro_type (attr)) | ||
| if (Attributes::is_proc_macro_type (attr) != tl::nullopt) |
There was a problem hiding this comment.
can this not just be if (Attributes::is_proc_macro_type (attr)) ?
| @@ -258,7 +261,7 @@ check_proc_macro_non_root (AST::AttrVec attributes, location_t loc) | |||
| { | |||
| for (auto &attr : attributes) | |||
| { | |||
| if (is_proc_macro_type (attr)) | |||
| if (Attributes::is_proc_macro_type (attr) != tl::nullopt) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc/rust/ChangeLog:
* checks/errors/privacy/rust-privacy-reporter.cc (find_proc_macro_attribute):"Removed checker function" (proc_macro_privacy_check): "modified checker implementation"
* util/rust-attributes.cc (is_proc_macro_type): "modifed fn into Attributes class" (Attributes::is_proc_macro_type): "modifed fn" (check_proc_macro_non_function): "modified checker implementation" (check_proc_macro_non_root): "modified checker implementation"
* util/rust-attributes.h: "included definition"
Thank you for making Rust GCC better!
If your PR fixes an issue, you can add "Fixes #issue_number" into this
PR description and the git commit message. This way the issue will be
automatically closed when your PR is merged. If your change addresses
an issue but does not fully fix it please mark it as "Addresses #issue_number"
in the git commit message.
Here is a checklist to help you with your PR.
make check-rustpasses locallyclang-formatgcc/testsuite/rust/Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.
Addresses #3291
*Please write a comment explaining your change. This is the message
that will be part of the merge commit.