refactor some attribute functions in rust-hir-map.cc and rust-early-name-resolver.cc #3344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* resolve/rust-early-name-resolver.cc (EarlyNameResolver::visit): "modified impl" * util/rust-attributes.cc (Attributes::is_rustc_builtin_macro): "helper function" * util/rust-attributes.h: "added" * util/rust-hir-map.cc (Mappings::insert_macro_def): "modified impl" Signed-off-by: Om Swaroop Nayak <96killerat96@gmail.com>
philberty
requested changes
Jan 10, 2025
| for (auto attr : outer_attrs) | ||
| { | ||
| if (attr.get_path () == Values::Attributes::RUSTC_BUILTIN_MACRO) | ||
| { |
There was a problem hiding this comment.
You can just do return true here no need for the extra braces
| bool | ||
| Attributes::is_rustc_builtin_macro (AST::AttrVec outer_attrs) | ||
| { | ||
| for (auto attr : outer_attrs) |
There was a problem hiding this comment.
you should probably do const auto attr
| @@ -37,6 +37,18 @@ Attributes::is_known (const std::string &attribute_path) | |||
|
|
|||
| return !lookup.is_error (); | |||
| } | |||
| bool | |||
| Attributes::is_rustc_builtin_macro (AST::AttrVec outer_attrs) | |||
There was a problem hiding this comment.
You should be using const AST::AttrVec& outer_attrs since this can be constified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc/rust/ChangeLog:
* resolve/rust-early-name-resolver.cc (EarlyNameResolver::visit): "modified impl"
* util/rust-attributes.cc (Attributes::is_rustc_builtin_macro): "helper function"
* util/rust-attributes.h: "added"
* util/rust-hir-map.cc (Mappings::insert_macro_def): "modified impl"
Thank you for making Rust GCC better!
If your PR fixes an issue, you can add "Fixes #issue_number" into this
PR description and the git commit message. This way the issue will be
automatically closed when your PR is merged. If your change addresses
an issue but does not fully fix it please mark it as "Addresses #issue_number"
in the git commit message.
Here is a checklist to help you with your PR.
make check-rustpasses locallyclang-formatgcc/testsuite/rust/Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.
Addresses #3291
*Please write a comment explaining your change. This is the message
that will be part of the merge commit.