p521: fix projective arithmetic tests #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests added in #950 weren't actually running due to feature gating (the feature is named `wip-arithmetic-do-not-use`, but the conditional gating was using `arithmetic` instead). It turns out a small modification to `primeorder` was needed, since the `impl_projective_arithmetic_tests` macro was relying on `Into` conversions from core arrays to `GenericArray` which top out at 64-element arrays, and `p521`'s field elements are 66-bytes. With the modification in place, the tests pass!
This was referenced Nov 2, 2023
Merged
tarcieri
added a commit
that referenced
this pull request
Nov 2, 2023
Now that #946, #950, and #951 have landed it seems prudent to add a real `arithmetic` feature. This adds a feature similar to the other crates in this repo which exposes the following types which provide a curve arithmetic implementation: - `AffinePoint` - `ProjectivePoint` - `Scalar` The `wip-arithmetic-do-not-use` feature is now removed as well. While technically SemVer breaking, it wasn't supposed to be used in the first place! Closes #947
tarcieri
added a commit
that referenced
this pull request
Nov 2, 2023
Now that #946, #950, and #951 have landed it seems prudent to add a real `arithmetic` feature. This adds a feature similar to the other crates in this repo which exposes the following types which provide a curve arithmetic implementation: - `AffinePoint` - `ProjectivePoint` - `Scalar` The `wip-arithmetic-do-not-use` feature is now removed as well. While technically SemVer breaking, it wasn't supposed to be used in the first place! Closes #947
tarcieri
added a commit
that referenced
this pull request
Nov 3, 2023
Now that #946, #950, and #951 have landed it seems prudent to add a real `arithmetic` feature. This adds a feature similar to the other crates in this repo which exposes the following types which provide a curve arithmetic implementation: - `AffinePoint` - `ProjectivePoint` - `Scalar` The `wip-arithmetic-do-not-use` feature is now removed as well. While technically SemVer breaking, it wasn't supposed to be used in the first place! Closes #947
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests added in #950 weren't actually running due to feature gating (the feature is named
wip-arithmetic-do-not-use, but the conditional gating was usingarithmeticinstead).It turns out a small modification to
primeorderwas needed, since theimpl_projective_arithmetic_testsmacro was relying onIntoconversions from core arrays toGenericArraywhich top out at 64-element arrays, andp521's field elements are 66-bytes.With the modification in place, the tests pass!