[READY] Merge master into v2.x (please don't squash commits!) #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a use-case for being able to cache the intermediate fetch of
metadata in case of temporary failures, so rather than:
parser.parse_remote(url)
I'd like to
begin
metadata = parser.get_idp_metadata(url, true)
do_my_caching(metadata)
parser.parse(metadata)
rescue HttpError
load_cache
end
There's a fair amount of logic in the get_idp_metadata method that I'd
rather not need to re-implement. Right now I have this implemented with
`parser.send(:get_idp_metadata, url, true)` which is obviously not great
if the internals of this class change in the future. Can we move this
method to the public API?
…tadata-public Make IdpMetadataParser#get_idp_metadata public
…sts-windows Master: Fix tests on Windows, add Ruby 3.3, and cleanup CI
* Use correct XPaths and resolve to correct elements * Update xml_security.rb * Block references that resolve to multiple nodes to prevent signature wrapping attacks
This test warns
warning: ambiguity between regexp and two divisions: wrap regexp in parentheses or add a space after `/' operator
We can fix this warning by using the %r regex syntax instead
johnnyshields
force-pushed
the
v2.x-merge-master-20240930
branch
from
183c5c4 to
6a11ca1
Compare
|
@pitbulk can you please merge this? (Without squashed commits) |
|
@johnnyshields, If I try "Rebase and Merge," it says there are conflicts. Is it okay to Create a Merge commit ("Merge PR")? |
|
Yes please! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.