Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is a policy for the ARC milter #850

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

lquidfire
Copy link
Contributor

@lquidfire lquidfire commented Jan 9, 2025

This policy file particularly targets OpenARC. The OpenARC milter is both an open source library for adding Authenticated Received Chain (ARC) support to applications, and an example filter application using the milter protocol.

The policy files are based on the dkim policy in this repository, with adaptions where useful.

Copy link
Member

@pebenito pebenito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Also see the lint errors from the GH actions.

policy/modules/services/arc.if Outdated Show resolved Hide resolved
policy/modules/services/arc.te Outdated Show resolved Hide resolved
policy/modules/services/arc.te Outdated Show resolved Hide resolved
policy/modules/services/arc.te Outdated Show resolved Hide resolved
@lquidfire
Copy link
Contributor Author

Minor comments. Also see the lint errors from the GH actions.

I believe that I have addressed all issues. Thank you for reviewing it!

@lquidfire lquidfire changed the title Add is a policy for the ARC milter This is a policy for the ARC milter Jan 9, 2025
@lquidfire lquidfire requested a review from pebenito January 9, 2025 18:47
@pebenito
Copy link
Member

pebenito commented Jan 9, 2025

If you rename the module to openarc and squash to 1 commit, it should be good to go.

@lquidfire
Copy link
Contributor Author

If you rename the module to openarc and squash to 1 commit, it should be good to go.

I changed the filenames, as well as the module name in openarc.te.

I squashed the commits, and force pushed them (I learned something new here). Thank you for your prompt assistance, this has been very helpful and a great experience for me!

This policy file particularly targets OpenARC. The OpenARC milter is both an open source library for adding Authenticated Received Chain (ARC) support to applications, and an example filter application using the milter protocol.

Signed-off-by: lquidfire <47566855+lquidfire@users.noreply.github.com>
@lquidfire
Copy link
Contributor Author

lquidfire commented Jan 11, 2025

Postfix was not allowed to write to the openarc stream socket, so I added openarc optionally to postfix.te (following the example of dkim in postfix.te).

I then also added openarc to cloudinit.te and sysadm.te, since I saw that dkim was also optionally added to those files, and it does make sense to add openarc to those.

Also squashed the commits again.

@pebenito pebenito merged commit 6186373 into SELinuxProject:main Jan 13, 2025
118 checks passed
@pebenito
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants