Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate detection issue by applying DML options with all-or-nothing behavior #1502

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Fix duplicate detection issue by applying DML options with all-or-nothing behavior #1502

merged 2 commits into from
Oct 8, 2024

Conversation

chininchu
Copy link
Contributor

Critical Changes

  • Fixed an issue where DUPLICATES_DETECTED errors were incorrectly thrown during DML operations, even when duplicates were allowed.

Changes

  • Added dml.OptAllOrNone = allOrNothing to ensure proper handling of DML operations based on the allOrNothing flag.
  • Adjusted DMLOptions to allow saving records with duplicates when allowSave is set.

Issues Closed

  • Resolved failures caused by duplicate rules during DML operations.
  • Ensured consistent handling of duplicate records based on configured rules.

@chininchu chininchu requested a review from aheber October 8, 2024 18:13
aheber
aheber approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@aheber aheber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for working through this and thank you so much for contributing to the project.

@aheber aheber merged commit 6db4cee into main Oct 8, 2024
3 checks passed
@aheber aheber deleted the feature/1007 branch October 8, 2024 18:24
@aheber aheber mentioned this pull request Oct 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aheber aheber aheber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chininchu @aheber