-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addPosition implemented, changes to election Model #69
base: master
Are you sure you want to change the base?
Conversation
Quick correction, the commit says event, that should say election. I keep getting the two names confused. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just implement the changes sofia brought up and I'll approve
…icationsOpen is true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Fixes #45
Description
addPosition creates a Position object and stores it in the positions array of the election document. The election model's positions array was changed to use a object literal array instead of a Positions object array(UPDATE)
The positions array is no longer a thing, addPositions now initializes a Position collection inside of our election document.
The elections collection has been renamed to election, and the singular election document should use "election" as it's ID.
Various function names were renamed from elections to election, e.g. closeElections is now closeElection
Types of changes
Checklist: