Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addPosition implemented, changes to election Model #69

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

BautistaBertolami
Copy link
Collaborator

@BautistaBertolami BautistaBertolami commented Nov 14, 2020

Fixes #45

Description

addPosition creates a Position object and stores it in the positions array of the election document. The election model's positions array was changed to use a object literal array instead of a Positions object array

(UPDATE)
The positions array is no longer a thing, addPositions now initializes a Position collection inside of our election document.
The elections collection has been renamed to election, and the singular election document should use "election" as it's ID.
Various function names were renamed from elections to election, e.g. closeElections is now closeElection

Types of changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Checklist:

  • My code follows the code style of this project found on ESLint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Sorry, something went wrong.

@BautistaBertolami
Copy link
Collaborator Author

Quick correction, the commit says event, that should say election. I keep getting the two names confused.

functions/src/Services/Elections.ts Outdated Show resolved Hide resolved
functions/src/Services/Elections.ts Outdated Show resolved Hide resolved
functions/src/Services/Elections.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@jeffjramos21 jeffjramos21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just implement the changes sofia brought up and I'll approve

Copy link
Collaborator

@jeffjramos21 jeffjramos21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addPosition func
4 participants