Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a new reference when iterating over a collection. #1080

Merged
merged 10 commits into from
Jan 27, 2025

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Jan 24, 2025

Description

Return a new reference when iterating over a collection and ensure that it is decreased again when the instances goes out of scope (memory managed by dlite).

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. However, I think that explaining somewher the reason for this is quite important. I suggest a clarifiying docstring at the top of the test.

@jesper-friis
Copy link
Collaborator Author

Nicely done. However, I think that explaining somewher the reason for this is quite important. I suggest a clarifiying docstring at the top of the test.

done

@francescalb francescalb merged commit 2702cf0 into master Jan 27, 2025
9 checks passed
@francescalb francescalb deleted the update-refcount branch January 27, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants