Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BDD/Remove Domain bdd_satmin and bdd_satmax #584

Merged
merged 8 commits into from
Nov 28, 2023

Conversation

SSoelvsten
Copy link
Owner

@SSoelvsten SSoelvsten commented Nov 27, 2023

Tasks

Also various code cleanup for anything traversal related... This makes src/bdd/evaluate.cpp and src/zdd/elem.cpp eerily similar. But, I have to think a bit more on how truly to merge the common pieces of code.

@SSoelvsten SSoelvsten added ✨ feature New operation or other feature 📁 bdd Binary Decision Diagrams 📁 zdd Zero-suppressed Decision Diagrams ❕ breaking version_number++ ✨ code quality Uncle Bob would be proud labels Nov 27, 2023
@SSoelvsten SSoelvsten self-assigned this Nov 27, 2023
@SSoelvsten SSoelvsten force-pushed the bdd/remove_domain_from_sat branch from a08b239 to 30501c4 Compare November 27, 2023 23:37
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (857313b) 96.951% compared to head (a08b239) 96.951%.
Report is 1 commits behind head on main.

❗ Current head a08b239 differs from pull request most recent head 8ddae36. Consider uploading reports for the commit 8ddae36 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #584   +/-   ##
=========================================
  Coverage   96.951%   96.951%           
=========================================
  Files           84        84           
  Lines         5871      5871           
=========================================
  Hits          5692      5692           
  Misses         179       179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SSoelvsten SSoelvsten merged commit 9a7e828 into main Nov 28, 2023
32 of 52 checks passed
@SSoelvsten SSoelvsten deleted the bdd/remove_domain_from_sat branch November 28, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📁 bdd Binary Decision Diagrams ❕ breaking version_number++ ✨ code quality Uncle Bob would be proud ✨ feature New operation or other feature 📁 zdd Zero-suppressed Decision Diagrams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bdd_mincube and bdd_maxcube Extend bdd_satmin and bdd_satmax with Consumer and Iterator output
1 participant