BDD/Remove Domain bdd_satmin
and bdd_satmax
#584
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
bdd_satmin
andbdd_satmax
with Domain #504 . Furthermore, does also ignores skipped levels of the BDD. This not only simplifies the code, but makesbdd_satmin
andbdd_satmax
closer to other BDD packages (e.g. BuDDy).bdd_mincube
andbdd_maxcube
redudant, asbdd_satmin
andbdd_satmax
already is this exact thing ( closes Addbdd_mincube
andbdd_maxcube
#454 ).bdd_satmin
andbdd_satmax
( closes Extendbdd_satmin
andbdd_satmax
with Consumer and Iterator output #225 )zdd_minelem
andzdd_maxelem
Also various code cleanup for anything traversal related... This makes src/bdd/evaluate.cpp and src/zdd/elem.cpp eerily similar. But, I have to think a bit more on how truly to merge the common pieces of code.