Double id bits in ptr_uint64 and other clean-up
#591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, we almost regain an entire bit for the level identifier, bringing it back to handle up to 6 TiB wide levels
…ring' This renaming does not show up in the history, since I rebased the pull request with (sadly only half of) the change.
This is much easier to guess on first look as to what it is supposed to do.
This function was only used in the test suite for Nested Sweeping while it is a source-code copy of '.as_ptr(...)'. In fact, I spend quite a bit of time tracking down a small bug in this that did not exist in '.as_ptr(...)'.
SSoelvsten
added
✨ code quality
It is kind of odd that the other bit-wise operators on pointers affects the flag, but this is not the case for bit-wise negation. Hence, by making it into a boolean negation we can differentiate between the two 'semantics'.
These functions are not used anywhere
…'level_info' This is to match the change with 'ptr_uint64'.
For almost all its uses, the 'operator!' is safe-guarded. Hence, we may as well just move it inside to clean up the rest of the code-base.
In this specific case, we know that both values are terminals. Hence, we may use the slightly faster 'operator~' function. It also flips the flag. But, the surrounding 'op(...)' removes it again
SSoelvsten
force-pushed
the
internal/ptr_uint64/more_id_bits
branch
from
7d7d198 to
39ce35c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #591 +/- ##
=============================================
- Coverage 96.974% 96.972% -0.003%
=============================================
Files 84 84
Lines 5883 5878 -5
=============================================
- Hits 5705 5700 -5
Misses 178 178 ☔ View full report in Codecov by Sentry. |
🟢 Regression Test (QBF 'breakthrough/3x4_19_bwnib')'origin/internal/ptr_uint64/more_id_bits' is a change in performance of 0.76% (stdev: 2.27%).
Number of samples: 4 |
🟢 Regression Test (QBF 'breakthrough/3x5_11_bwnib')'origin/internal/ptr_uint64/more_id_bits' is a change in performance of 0.75% (stdev: 1.18%).
Number of samples: 5 |
🟢 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')'origin/internal/ptr_uint64/more_id_bits' is a change in performance of 1.32% (stdev: 3.68%).
Number of samples: 5 |
🟡 Regression Test (Picotrav 'arbiter')'origin/internal/ptr_uint64/more_id_bits' is a change in performance of -0.61% (stdev: 0.97%).
Number of samples: 4 |
🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')'origin/internal/ptr_uint64/more_id_bits' is a change in performance of 2.07% (stdev: 3.61%).
Number of samples: 5 |
🔴 Regression Test (Picotrav 'mem_ctrl')'origin/internal/ptr_uint64/more_id_bits' is a change in performance of -1.03% (stdev: 0.39%).
Number of samples: 4 |
🟡 Regression Test (Picotrav 'adder')'origin/internal/ptr_uint64/more_id_bits' is a change in performance of -6.35% (stdev: 11.74%).
Number of samples: 10 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double the maximum width of
bddandzddto 6 TiB at the cost of decreasing the maximum label by two. Furthermore, now that am looking back at this code from the prior refactor, I also clean up a few other things related to the pointer and add missing unit tests.