Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project/2023/boolean optimisation #612

Merged
merged 13 commits into from
Feb 13, 2024
Merged

Conversation

SSoelvsten
Copy link
Owner

Merge of MSc course project by Erik Funder Carstensen ( @halvko ) into main. I have added unit tests.

Create internal/optmin.h as a copy of internal/count.h, add stats boiler
plate and make a first draft of the public interface for optmin
Also fixes compatibility issues with updated upstream
@SSoelvsten SSoelvsten added ✨ feature New operation or other feature 📁 bdd Binary Decision Diagrams labels Feb 13, 2024
@SSoelvsten SSoelvsten self-assigned this Feb 13, 2024
Copy link

github-actions bot commented Feb 13, 2024

Cppcheck

nofile:0:0: information: Cppcheck cannot find all the include files (use --check-config for details) [missingInclude]

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ac7b771) 97.185% compared to head (419b94d) 97.159%.

Files Patch % Lines
src/adiar/statistics.cpp 84.615% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              main      #612       +/-   ##
=============================================
- Coverage   97.185%   97.159%   -0.027%     
=============================================
  Files           88        88               
  Lines         6111      6124       +13     
=============================================
+ Hits          5939      5950       +11     
- Misses         172       174        +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 13, 2024

🔴 Regression Test (Picotrav 'mem_ctrl')

'origin/project/2023/boolean-optimisation' is a change in performance of -0.87% (stdev: 0.40%).

... origin/main origin/project/2023/boolean-optimisation
Mean 111590.67 112556.67
Standard Deviation 449.79 183.83

Number of samples: 3

Copy link

github-actions bot commented Feb 13, 2024

🟢 Regression Test (Picotrav 'adder')

'origin/project/2023/boolean-optimisation' is a change in performance of 4.87% (stdev: 12.42%).

... origin/main origin/project/2023/boolean-optimisation
Mean 10042.40 9553.60
Standard Deviation 1247.01 845.61

Number of samples: 10

Copy link

github-actions bot commented Feb 13, 2024

🟡 Regression Test (Picotrav 'arbiter')

'origin/project/2023/boolean-optimisation' is a change in performance of -0.56% (stdev: 0.86%).

... origin/main origin/project/2023/boolean-optimisation
Mean 63066.50 63416.75
Standard Deviation 541.55 281.27

Number of samples: 4

Copy link

github-actions bot commented Feb 13, 2024

🟢 Regression Test (QBF 'breakthrough/3x5_11_bwnib')

'origin/project/2023/boolean-optimisation' is a change in performance of 0.64% (stdev: 1.89%).

... origin/main origin/project/2023/boolean-optimisation
Mean 9979.60 9915.60
Standard Deviation 188.25 63.61

Number of samples: 5

Copy link

github-actions bot commented Feb 13, 2024

🟡 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'origin/project/2023/boolean-optimisation' is a change in performance of -0.07% (stdev: 0.81%).

... origin/main origin/project/2023/boolean-optimisation
Mean 28506.60 28525.40
Standard Deviation 168.04 230.40

Number of samples: 5

Copy link

github-actions bot commented Feb 13, 2024

🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')

'origin/project/2023/boolean-optimisation' is a change in performance of 1.50% (stdev: 3.69%).

... origin/main origin/project/2023/boolean-optimisation
Mean 30587.20 30128.40
Standard Deviation 1129.66 170.91

Number of samples: 5

@SSoelvsten SSoelvsten force-pushed the project/2023/boolean-optimisation branch from e131b45 to 9c29b58 Compare February 13, 2024 10:35
@SSoelvsten SSoelvsten force-pushed the project/2023/boolean-optimisation branch from 5ecee30 to 419b94d Compare February 13, 2024 10:48
Copy link

🟢 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'origin/project/2023/boolean-optimisation' is a change in performance of 1.48% (stdev: 5.64%).

... origin/main origin/project/2023/boolean-optimisation
Mean 44503.60 43843.00
Standard Deviation 2509.82 593.70

Number of samples: 10

@SSoelvsten SSoelvsten merged commit fba2df5 into main Feb 13, 2024
51 of 54 checks passed
@SSoelvsten SSoelvsten deleted the project/2023/boolean-optimisation branch April 19, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📁 bdd Binary Decision Diagrams ✨ feature New operation or other feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants