`bdd_satmin` and `bdd_satmax` with set of variables #666

SSoelvsten · 2024-05-30T08:30:23Z

Cleans up some code to then close #665 and solve parts of #519 .

…ators To this end, we'll start to create our own 'type_traits' aliases to make the expressions much more readable.

This makes it much easier to read the return type

github-actions · 2024-05-30T09:06:05Z

🟡 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')

'ssoelvsten/adiar/bdd/sat_with_domain' is a change in performance of -0.36% (stdev: 1.23%).

...	origin/main	ssoelvsten/adiar/bdd/sat_with_domain
Mean	5051.30	5069.50
Standard Deviation	38.80	62.25

Number of samples: 10

github-actions · 2024-05-30T09:06:11Z

🟡 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')

'ssoelvsten/adiar/bdd/sat_with_domain' is a change in performance of -0.10% (stdev: 0.38%).

...	origin/main	ssoelvsten/adiar/bdd/sat_with_domain
Mean	11979.80	11991.50
Standard Deviation	45.87	30.83

Number of samples: 10

github-actions · 2024-05-30T09:06:37Z

🟡 Regression Test (QBF 'domineering/5x5_13_bwnib')

'ssoelvsten/adiar/bdd/sat_with_domain' is a change in performance of -0.21% (stdev: 1.24%).

...	origin/main	ssoelvsten/adiar/bdd/sat_with_domain
Mean	15147.50	15179.90
Standard Deviation	47.60	187.79

Number of samples: 10

github-actions · 2024-05-30T09:07:24Z

🟡 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')

'ssoelvsten/adiar/bdd/sat_with_domain' is a change in performance of -0.15% (stdev: 0.78%).

...	origin/main	ssoelvsten/adiar/bdd/sat_with_domain
Mean	16879.20	16903.90
Standard Deviation	87.59	132.56

Number of samples: 10

github-actions · 2024-05-30T09:07:32Z

🟢 Regression Test (Picotrav 'adder')

'ssoelvsten/adiar/bdd/sat_with_domain' is a change in performance of 0.31% (stdev: 0.37%).

...	origin/main	ssoelvsten/adiar/bdd/sat_with_domain
Mean	9523.67	9494.00
Standard Deviation	28.43	35.37

Number of samples: 3

github-actions · 2024-05-30T09:07:42Z

🟢 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'ssoelvsten/adiar/bdd/sat_with_domain' is a change in performance of 0.40% (stdev: 1.14%).

...	origin/main	ssoelvsten/adiar/bdd/sat_with_domain
Mean	21782.10	21694.20
Standard Deviation	249.16	115.57

Number of samples: 10

github-actions · 2024-05-30T09:08:13Z

🟡 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'ssoelvsten/adiar/bdd/sat_with_domain' is a change in performance of -0.30% (stdev: 0.48%).

...	origin/main	ssoelvsten/adiar/bdd/sat_with_domain
Mean	29203.80	29292.70
Standard Deviation	91.94	140.91

Number of samples: 10

codecov · 2024-05-30T09:09:00Z

Codecov Report

Attention: Patch coverage is 94.11765% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 97.301%. Comparing base (d41169a) to head (050f43d).

❗ Current head 050f43d differs from pull request most recent head dea9687

Please upload reports for the commit dea9687 to get more accurate results.

Files	Patch %	Lines
src/adiar/bdd/evaluate.cpp	90.000%	6 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##              main      #666       +/-   ##
=============================================
- Coverage   97.375%   97.301%   -0.075%     
=============================================
  Files           90        90               
  Lines         6515      6557       +42     
=============================================
+ Hits          6344      6380       +36     
- Misses         171       177        +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-05-30T09:12:19Z

🟢 Regression Test (12-Queens)

'ssoelvsten/adiar/bdd/sat_with_domain' is a change in performance of 0.03% (stdev: 0.63%).

...	origin/main	ssoelvsten/adiar/bdd/sat_with_domain
Mean	11767.90	11764.80
Standard Deviation	74.69	74.66

Number of samples: 10

github-actions · 2024-05-30T09:12:41Z

🟡 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')

'ssoelvsten/adiar/bdd/sat_with_domain' is a change in performance of -0.43% (stdev: 2.11%).

...	origin/main	ssoelvsten/adiar/bdd/sat_with_domain
Mean	9407.10	9447.10
Standard Deviation	162.36	199.65

Number of samples: 10

github-actions · 2024-05-30T09:13:11Z

🟢 Regression Test (Picotrav 'arbiter')

'ssoelvsten/adiar/bdd/sat_with_domain' is a change in performance of 0.04% (stdev: 0.42%).

...	origin/main	ssoelvsten/adiar/bdd/sat_with_domain
Mean	65204.11	65175.44
Standard Deviation	270.61	207.64

Number of samples: 9

github-actions · 2024-05-30T09:13:13Z

🟢 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')

'ssoelvsten/adiar/bdd/sat_with_domain' is a change in performance of 0.21% (stdev: 0.72%).

...	origin/main	ssoelvsten/adiar/bdd/sat_with_domain
Mean	5162.20	5151.40
Standard Deviation	37.08	36.98

Number of samples: 10

github-actions · 2024-05-30T09:20:31Z

🟡 Regression Test (Picotrav 'mem_ctrl')

'ssoelvsten/adiar/bdd/sat_with_domain' is a change in performance of -0.08% (stdev: 0.21%).

...	origin/main	ssoelvsten/adiar/bdd/sat_with_domain
Mean	113536.40	113629.40
Standard Deviation	239.72	241.45

Number of samples: 5

github-actions · 2024-05-30T10:58:45Z

🟡 Regression Test (14-Queens)

'ssoelvsten/adiar/bdd/sat_with_domain' is a change in performance of -0.17% (stdev: 0.37%).

...	origin/main	ssoelvsten/adiar/bdd/sat_with_domain
Mean	271614.33	272065.00
Standard Deviation	453.04	1006.62

Number of samples: 3

SSoelvsten added 9 commits May 29, 2024 11:14

Fix lingering misuse of 'std::forward<...>'

620cd96

Remove undesired whitespace

77ba767

Decrease number of bits for level to 21

ce0f58c

Fix 'std::enable_if' has incorrect conditional for 'exec_policy' oper…

ee73964

…ators To this end, we'll start to create our own 'type_traits' aliases to make the expressions much more readable.

Move SFINAE into template parameters

83a1166

This makes it much easier to read the return type

Overload 'bdd_satmin' and 'bdd_satmax' with to-be included variables

5989a39

Remove slight hack to not trigger templated iterator function

5e498ac

Improve code quality for 'make_generator(...)' functions

0ecd02c

Overload 'bdd_satmin' and 'bdd_satmax' with symbolic set of variables

a85f186

SSoelvsten added ✨ feature New operation or other feature 📁 bdd Binary Decision Diagrams ✨ code quality Uncle Bob would be proud labels May 30, 2024

SSoelvsten added this to the v2.1 : Relational Product milestone May 30, 2024

SSoelvsten self-assigned this May 30, 2024

Format latest changes

050f43d

SSoelvsten added 2 commits May 30, 2024 11:38

Remove dead code for 'bdd_satmin' and 'bdd_satmax' with consumers

dea9687

Fix 'unused variable' warnings from Clang

c84dd21

SSoelvsten merged commit 9e79baa into main May 30, 2024
15 checks passed

SSoelvsten deleted the bdd/sat_with_domain branch June 7, 2024 07:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`bdd_satmin` and `bdd_satmax` with set of variables #666

`bdd_satmin` and `bdd_satmax` with set of variables #666

SSoelvsten commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

codecov bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024

bdd_satmin and bdd_satmax with set of variables #666

bdd_satmin and bdd_satmax with set of variables #666

Conversation

SSoelvsten commented May 30, 2024 • edited Loading

github-actions bot commented May 30, 2024 • edited Loading

🟡 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')

github-actions bot commented May 30, 2024 • edited Loading

🟡 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')

github-actions bot commented May 30, 2024 • edited Loading

🟡 Regression Test (QBF 'domineering/5x5_13_bwnib')

github-actions bot commented May 30, 2024 • edited Loading

🟡 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')

github-actions bot commented May 30, 2024

🟢 Regression Test (Picotrav 'adder')

github-actions bot commented May 30, 2024 • edited Loading

🟢 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

github-actions bot commented May 30, 2024 • edited Loading

🟡 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

codecov bot commented May 30, 2024 • edited Loading

Codecov Report

github-actions bot commented May 30, 2024 • edited Loading

🟢 Regression Test (12-Queens)

github-actions bot commented May 30, 2024 • edited Loading

🟡 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')

github-actions bot commented May 30, 2024 • edited Loading

🟢 Regression Test (Picotrav 'arbiter')

github-actions bot commented May 30, 2024 • edited Loading

🟢 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')

github-actions bot commented May 30, 2024 • edited Loading

🟡 Regression Test (Picotrav 'mem_ctrl')

github-actions bot commented May 30, 2024

🟡 Regression Test (14-Queens)

`bdd_satmin` and `bdd_satmax` with set of variables #666

`bdd_satmin` and `bdd_satmax` with set of variables #666

SSoelvsten commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

codecov bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading