Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BDD/RelNext/Renaming #675

Merged
merged 4 commits into from
Jun 14, 2024
Merged

BDD/RelNext/Renaming #675

merged 4 commits into from
Jun 14, 2024

Conversation

SSoelvsten
Copy link
Owner

@SSoelvsten SSoelvsten commented Jun 14, 2024

Optimisation from #502 : Integrates the relabelling directly within the bdd_exists nested sweep.

@SSoelvsten SSoelvsten added the ✨ optimisation It's all about speed / space label Jun 14, 2024
@SSoelvsten SSoelvsten added this to the v2.1 : Relational Product milestone Jun 14, 2024
@SSoelvsten SSoelvsten self-assigned this Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.871%. Comparing base (469dfa8) to head (48db57c).
Report is 1 commits behind head on main.

Current head 48db57c differs from pull request most recent head 2e7a6e2

Please upload reports for the commit 2e7a6e2 to get more accurate results.

Additional details and impacted files
@@              Coverage Diff              @@
##              main      #675       +/-   ##
=============================================
+ Coverage   97.862%   97.871%   +0.009%     
=============================================
  Files           93        93               
  Lines         6970      6998       +28     
=============================================
+ Hits          6821      6849       +28     
  Misses         149       149               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 14, 2024

🟢 Regression Test (12-Queens)

'ssoelvsten/adiar/bdd/relnext/renaming' is a change in performance of 0.13% (stdev: 0.45%).

... origin/main ssoelvsten/adiar/bdd/relnext/renaming
Mean 11372.40 11357.50
Standard Deviation 51.55 47.78

Number of samples: 10

Copy link

github-actions bot commented Jun 14, 2024

🟢 Regression Test (Picotrav 'arbiter')

'ssoelvsten/adiar/bdd/relnext/renaming' is a change in performance of 8.40% (stdev: 20.00%).

... origin/main ssoelvsten/adiar/bdd/relnext/renaming
Mean 73593.60 67410.60
Standard Deviation 14718.97 9635.35

Number of samples: 10

Copy link

github-actions bot commented Jun 14, 2024

🟡 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')

'ssoelvsten/adiar/bdd/relnext/renaming' is a change in performance of -0.26% (stdev: 0.41%).

... origin/main ssoelvsten/adiar/bdd/relnext/renaming
Mean 12079.20 12110.40
Standard Deviation 49.82 39.67

Number of samples: 10

Copy link

github-actions bot commented Jun 14, 2024

🟡 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')

'ssoelvsten/adiar/bdd/relnext/renaming' is a change in performance of -0.04% (stdev: 0.77%).

... origin/main ssoelvsten/adiar/bdd/relnext/renaming
Mean 5210.70 5212.60
Standard Deviation 25.51 39.88

Number of samples: 10

Copy link

github-actions bot commented Jun 14, 2024

🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')

'ssoelvsten/adiar/bdd/relnext/renaming' is a change in performance of 0.22% (stdev: 0.32%).

... origin/main ssoelvsten/adiar/bdd/relnext/renaming
Mean 15353.00 15319.10
Standard Deviation 49.77 38.32

Number of samples: 10

Copy link

github-actions bot commented Jun 14, 2024

🟡 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'ssoelvsten/adiar/bdd/relnext/renaming' is a change in performance of -0.09% (stdev: 1.45%).

... origin/main ssoelvsten/adiar/bdd/relnext/renaming
Mean 29963.30 29991.60
Standard Deviation 322.21 433.82

Number of samples: 10

Copy link

github-actions bot commented Jun 14, 2024

🟡 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'ssoelvsten/adiar/bdd/relnext/renaming' is a change in performance of -0.09% (stdev: 0.41%).

... origin/main ssoelvsten/adiar/bdd/relnext/renaming
Mean 22018.80 22038.50
Standard Deviation 68.85 90.86

Number of samples: 10

Copy link

github-actions bot commented Jun 14, 2024

🟡 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')

'ssoelvsten/adiar/bdd/relnext/renaming' is a change in performance of -0.78% (stdev: 0.95%).

... origin/main ssoelvsten/adiar/bdd/relnext/renaming
Mean 5076.90 5116.40
Standard Deviation 23.53 48.39

Number of samples: 10

Copy link

github-actions bot commented Jun 14, 2024

🟡 Regression Test (Picotrav 'mem_ctrl')

'ssoelvsten/adiar/bdd/relnext/renaming' is a change in performance of -0.03% (stdev: 0.29%).

... origin/main ssoelvsten/adiar/bdd/relnext/renaming
Mean 116405.40 116437.00
Standard Deviation 283.21 340.36

Number of samples: 5

Copy link

github-actions bot commented Jun 14, 2024

🟡 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')

'ssoelvsten/adiar/bdd/relnext/renaming' is a change in performance of -2.76% (stdev: 8.69%).

... origin/main ssoelvsten/adiar/bdd/relnext/renaming
Mean 16991.20 17459.80
Standard Deviation 105.97 1517.38

Number of samples: 10

Copy link

github-actions bot commented Jun 14, 2024

🟡 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')

'ssoelvsten/adiar/bdd/relnext/renaming' is a change in performance of -0.14% (stdev: 0.82%).

... origin/main ssoelvsten/adiar/bdd/relnext/renaming
Mean 9589.70 9603.60
Standard Deviation 78.68 60.27

Number of samples: 10

Copy link

github-actions bot commented Jun 14, 2024

🟡 Regression Test (Picotrav 'adder')

'ssoelvsten/adiar/bdd/relnext/renaming' is a change in performance of -3.22% (stdev: 8.68%).

... origin/main ssoelvsten/adiar/bdd/relnext/renaming
Mean 9368.10 9669.90
Standard Deviation 55.21 839.08

Number of samples: 10

@SSoelvsten SSoelvsten force-pushed the bdd/relnext/renaming branch from 48db57c to 2e7a6e2 Compare June 14, 2024 13:13
@SSoelvsten SSoelvsten merged commit 7c308b6 into main Jun 14, 2024
56 of 59 checks passed
Copy link

🟢 Regression Test (14-Queens)

'ssoelvsten/adiar/bdd/relnext/renaming' is a change in performance of 0.17% (stdev: 0.21%).

... origin/main ssoelvsten/adiar/bdd/relnext/renaming
Mean 261499.33 261059.00
Standard Deviation 547.79 278.68

Number of samples: 3

@SSoelvsten SSoelvsten deleted the bdd/relnext/renaming branch June 14, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ optimisation It's all about speed / space
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant