-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix statistics for quantification runs and transposition sweeps are misleading #693
Conversation
9792c6a
to
7c70c18
Compare
b8ee0fc
to
715ae54
Compare
🟡 Regression Test (QBF 'breakthrough/3x4_19_bwnib')'ssoelvsten/adiar/internal/quantify/statistics_fix' is a change in performance of -1.15% (stdev: 1.38%).
Number of samples: 3 |
🟡 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')'ssoelvsten/adiar/internal/quantify/statistics_fix' is a change in performance of -1.01% (stdev: 1.30%).
Number of samples: 3 |
🟡 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')'ssoelvsten/adiar/internal/quantify/statistics_fix' is a change in performance of 0.55% (stdev: 0.56%).
Number of samples: 3 |
🟡 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')'ssoelvsten/adiar/internal/quantify/statistics_fix' is a change in performance of -0.14% (stdev: 1.17%).
Number of samples: 3 |
🟡 Regression Test (Picotrav 'adder')'ssoelvsten/adiar/internal/quantify/statistics_fix' is a change in performance of -0.14% (stdev: 10.90%).
Number of samples: 10 |
🟡 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')'ssoelvsten/adiar/internal/quantify/statistics_fix' is a change in performance of 2.43% (stdev: 2.28%).
Number of samples: 3 |
🟡 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')'ssoelvsten/adiar/internal/quantify/statistics_fix' is a change in performance of 0.45% (stdev: 0.80%).
Number of samples: 3 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
=============================================
+ Coverage 98.040% 98.049% +0.008%
=============================================
Files 93 93
Lines 7093 7123 +30
=============================================
+ Hits 6954 6984 +30
Misses 139 139 ☔ View full report in Codecov by Sentry. |
🟡 Regression Test (12-Queens)'ssoelvsten/adiar/internal/quantify/statistics_fix' is a change in performance of -0.30% (stdev: 0.65%).
Number of samples: 3 |
🟡 Regression Test (Picotrav 'arbiter')'ssoelvsten/adiar/internal/quantify/statistics_fix' is a change in performance of -0.23% (stdev: 16.22%).
Number of samples: 8 |
🟡 Regression Test (QBF 'domineering/5x5_13_bwnib')'ssoelvsten/adiar/internal/quantify/statistics_fix' is a change in performance of 0.42% (stdev: 0.58%).
Number of samples: 3 |
🟡 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')'ssoelvsten/adiar/internal/quantify/statistics_fix' is a change in performance of -1.17% (stdev: 2.94%).
Number of samples: 3 |
🟡 Regression Test (Picotrav 'mem_ctrl')'ssoelvsten/adiar/internal/quantify/statistics_fix' is a change in performance of -0.22% (stdev: 0.41%).
Number of samples: 3 |
🟡 Regression Test (14-Queens)'ssoelvsten/adiar/internal/quantify/statistics_fix' is a change in performance of -0.34% (stdev: 0.30%).
Number of samples: 3 |
7c70c18
to
663b291
Compare
…isleading Warning: this is technically a breaking change to the public API. Sorry! But, you didn't use this part anyway... right...?
663b291
to
cfc7f07
Compare
Closes #644
Warning: this is technically a breaking change to the public API. Sorry! But, you didn't use this part anyway... right...? I won't bother upping the version number due to this.