SHS-5988: Fix empty heading on postcards without title #1699
Conversation
|
@ahughes3 Please take a look at this comment before approving the PR. The Chemistry site is not in Tugboat, but the existing links in the cards break after applying this fix. I think that the fix is still necessary, but descriptive titles should be added if they want to keep the links working. |
| if (!empty($variables['title'])) { | ||
| $title = is_array($variables['title']) ? $renderer->renderInIsolation($variables['title']) : $variables['title']; | ||
| $variables['title'] = ['#markup' => trim(strip_tags($title))]; | ||
| $variables['title'] = $title ?? ['#markup' => trim(strip_tags($title))]; |
There was a problem hiding this comment.
Why does this work? I'm not really understanding.
if $variables['title'] is a render array, we get the rendering, otherwise it's would be a string. But either way $title is not null/false, so it would always set the value to what is returned in line 187. The ?? .... doesn't really do anything at this point.
There was a problem hiding this comment.
The thing is that in line 187 $title returned an empty string. So in line 188, if we don't add the ?? it will set $variables['title'] like this:
$variables['title'] will return an array in these scenario, so in the template vertical-card.html.twig it will seem that there's something in title even though it's an array with an #markup that is empty. This will add the h2.
READY FOR REVIEW
Summary
Fix empty heading on postcards without title
Urgency
medium
Steps to Test
Vertical Postcards with Title, Image and Link in a CollectionandVertical Postcards with Title and Image in a Collection(first of the third row of cards)PR Checklist