SHS-5955: When first adding Footer Social Media Links there is strange scrolling when adding another link #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codechefmarc
requested review from
callinmullaney and
cienvaras
and removed request for
cienvaras
cienvaras
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
@codechefmarc Works great, thanks!
@ahughes3 Ready for you to review.
cienvaras
requested review from
ahughes3
and removed request for
callinmullaney
pookmish
requested changes
Jan 13, 2025
composer.json
Outdated
| @@ -229,6 +229,9 @@ | |||
| "extra": { | |||
| "enable-patching": true, | |||
| "patches": { | |||
| "drupal/block_class": { | |||
| "Click JavaScript to close details causes modals to scroll unnecessarily https://www.drupal.org/project/block_class/issues/3497768": "https://git.drupalcode.org/project/block_class/-/merge_requests/60.patch" | |||
There was a problem hiding this comment.
We have been avoiding git url patches because if the branch changes, it can cause problems. Download the patch into the repo and reference it via relative path.
There was a problem hiding this comment.
Changed to patch in repo.
pookmish
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
block_classmodule to fix the issue when clicking on our "Add another item" button in the social media block would scroll the modal to the bottom.block_classto version 4Need Review By (Date)
2025-01-08
Urgency
low
Steps to Test
/admin/structure/blockPR Checklist