Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5991: Text is clipped when resized #1712

Open
wants to merge 3 commits into
base: 11.6.3-release
Choose a base branch
from

Conversation

mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Jan 9, 2025

Summary

This PR remove the CSS overflow: hidden property to all the list items without a class and add that property only to the ones that need it. SiteImprove is flagging this as an a issue.

Urgency

medium

Steps to Test

  1. On Colorful and Traditional
  2. Go to any page that has component that uses a WYSIWYG editor (one that can include images and bulleted lists or numbered lists). For example this path: /components/text-area-typography, /components/accordions.
  3. Edit the component and add an image aligned to the left and some text with bulleted or numbered list at the right. The CSS overflow: hidden property is only preventing the list item to float behind images that are floated to the left.
  4. Confirm the list items are looking as expected
  5. Other lists like the ones in the footer component should look the same and shouldn't use that CSS overflow: hidden property

@ahughes3 ahughes3 temporarily deployed to Tugboat January 9, 2025 19:10 Destroyed
@mariannuar mariannuar self-assigned this Jan 9, 2025
Copy link
Collaborator

@callinmullaney callinmullaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar Seems to be resolved from my end. Thanks for adding the inline comment for clarity of where this styling is being applied.

@callinmullaney
Copy link
Collaborator

@ahughes3 This PR is ready for you. I was able to confirm this locally but (as of this morning) I'm seeing a "Oops! Something went wrong..." from the tugboat links. I triggered a refresh on tugboats side of things so hopefully this resolves itself with the rebuild. If you're having trouble viewing the links just let me know and I'll trigger a full rebuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants