Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS-6009: Remove Visibility and Region fields from the Social Media footer block for Site Editors #1715

Open
wants to merge 2 commits into
base: 11.6.3-release
Choose a base branch
from
Open

SHS-6009: Remove Visibility and Region fields from the Social Media footer block for Site Editors #1715

wants to merge 2 commits into from

Conversation

codechefmarc
Copy link
Collaborator

@codechefmarc codechefmarc commented Jan 13, 2025 •
edited
Loading

Summary

When editing the social media footer block, site managers will no longer see the "Visibility" and "Region" fields. Developer roles will still see these fields.

Need Review By (Date)

2025-01-15

Urgency

low

Steps to Test

  1. Login to the site as a Developer
  2. Add a social media block to the system (typically in the footer)
  3. Verify that the Visibility and Region fields are present

Screenshot 2025-01-13 at 12 38 52 PM

  1. Add in a link and then save the block
  2. Masquerade as a site manager (Lindsay is usually our test user for this case)

Screenshot 2025-01-13 at 12 42 26 PM

  1. Go the home page
  2. Hover over the social media block and click the pencil icon, then clock "Edit Social Media block"

Screenshot 2025-01-13 at 12 40 20 PM

  1. Verify that as a site manager role, the Visibility and Region fields are no longer visible

Screenshot 2025-01-13 at 12 41 29 PM

Review Tasks

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Are PHP functions and variables in snake_case and not camelCase?
  • Does Drupal code follow Drupal Coding Standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided?

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

@codechefmarc codechefmarc self-assigned this Jan 13, 2025
@codechefmarc codechefmarc changed the base branch from develop to 11.6.3-release January 13, 2025 20:25
@ahughes3 ahughes3 temporarily deployed to Tugboat January 13, 2025 20:28 Destroyed
@codechefmarc codechefmarc marked this pull request as ready for review January 13, 2025 22:04
callinmullaney
callinmullaney approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@callinmullaney callinmullaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codechefmarc Nice work! Confirming that I no longer see these visibility regions for non-administrator roles.
Screenshot 2025-01-15 at 8 47 57 AM

@callinmullaney
Copy link
Collaborator

@ahughes3 Functional tests pass and the code looks good to me. Kicking this over to you for confirmation.

@ahughes3
Copy link
Collaborator

Tugboat has finished building the preview for this pull request!

Links:

Dashboard:

Visual Diffs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callinmullaney callinmullaney callinmullaney approved these changes

@ahughes3 ahughes3 Awaiting requested review from ahughes3

Assignees

@ahughes3 ahughes3

Labels
Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codechefmarc @callinmullaney @ahughes3