Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOEOPSFY24-163 | fixup news card link bug #123

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

rebeccahongsf
Copy link
Contributor

READY FOR REVIEW

Summary

  • fixup news card link bug

Review By (Date)

  • When possible

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Spin up gitpod or local dev
  3. Create a News content type with a length name
  4. Add a List paragraph with a News > Card Grid view to the homepage
  5. Navigate to the homepage
  6. Verify that the underline spans the text and not the content box
  7. Review code

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory? Nope

Front End Validation

Affected Projects or Products

  • Scope to SOE only

Associated Issues and/or People

  • SOEOPSFY24-163

Copy link
Contributor

@buttonwillowsix buttonwillowsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-09-27 at 8 27 18 PM Hey, that looks great! Based on your notes, I can totally see why we need that change. Text styling that is dependent on things like line-breaks and whatnot often doesn't work well unless there are the correct display options.

@imonroe imonroe merged commit 9913419 into 11.x Oct 15, 2024
3 of 4 checks passed
@imonroe imonroe deleted the bug/SOEOPSFY24-163--newsCardLink branch October 15, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants