Add smoke tests for stunnel #688
Open
+326
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcermak
force-pushed
the
stunnel-tests
branch
from
fab5f6c to
c6e256a
Compare
dcermak
force-pushed
the
stunnel-tests
branch
from
c6e256a to
f34c405
Compare
grisu48
reviewed
Jan 21, 2025
dcermak
force-pushed
the
stunnel-tests
branch
from
f34c405 to
ed1a8f6
Compare
alexandrevicenzi
previously approved these changes
Jan 22, 2025
| "STUNNEL_DEBUG": log_level, | ||
| "STUNNEL_SERVICE_NAME": "neverssl", | ||
| "STUNNEL_ACCEPT": f"0.0.0.0:{_CTR_PORT}", | ||
| "STUNNEL_CONNECT": "neverssl.com:80", |
There was a problem hiding this comment.
nit: can we trust this won't cause random failures in CI?
dcermak
force-pushed
the
stunnel-tests
branch
from
ed1a8f6 to
7621fb9
Compare
grisu48
approved these changes
Jan 23, 2025
| resp = get_request_to_stunnel() | ||
| assert resp.status_code == 200 | ||
| assert ( | ||
| "This website is for when you try to open Facebook, Google, Amazon, etc" |
There was a problem hiding this comment.
Suggested change
| "This website is for when you try to open Facebook, Google, Amazon, etc" | |
| assert "neverssl" in resp.text.lower() |
Making assumptions on external resources we have no control over is always difficult. I would limit the assumption to a minimum, so that the test doesn't fail when someone slightly changes the text on neverssl.com. We already check for status code 200, I think this check doesn't need to be extensive here.
alexandrevicenzi
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CI:TOXENVS] stunnel
for SUSE/BCI-dockerfile-generator#2110