Add ansible playbook syntax check #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpagot
force-pushed
the
ansible_syntax
branch
from
ff62ee2 to
62bf1e1
Compare
Call ansible-playbook for each playbook using --syntax-check. Dummy roles and inventory is provided to avoid false error detection. The python script also format the error output to be compliant to github pipeline standard. Add Github pipeline to run this test.
mpagot
force-pushed
the
ansible_syntax
branch
from
62bf1e1 to
4cabc2e
Compare
mpagot
commented
Nov 27, 2023
| @@ -12,7 +12,12 @@ jobs: | |||
| - name: Install all requirements | |||
| run: | | |||
| python3 -m pip install --upgrade -r requirements.txt | |||
| ansible-galaxy install -r requirements.yml | |||
There was a problem hiding this comment.
What is interesting is that calling ansible-playbook also need al Ansible dependency to be ok. So this test is also an indirect test for the Ansible dependency.
mpagot
commented
Nov 27, 2023
| @@ -3,7 +3,7 @@ venv/ | |||
| **/.venv/ | |||
| **/__pycache__/ | |||
| secret/ | |||
| inventory.yaml | |||
| terraform/**/inventory.yaml | |||
There was a problem hiding this comment.
Needed not to ignore the dummy inventory in the tools folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call ansible-playbook for each playbook using --syntax-check.
Dummy roles and inventory is provided to avoid false error detection.
The python script also format the error output to be compliant to github pipeline standard.
Add Github pipeline to run this test.
Ticket : TEAM-7184
Verification: is the pipeline execution in this PR
Here how an error will looks like
