Try to make random sampling for unbinding reproducible #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the seed for the random shuffle used in unbinding depend on the particle IDs so that the random number sequence no longer depends on the (unpredictable) order in which threads process halos. It also adds a parameter that can be used to change the seed so that we can run multiple realizations. Particle IDs are xor'd with the supplied parameter and then used to initialize the random number generator. I'm not sure if some other operation would make more sense.
I think this change also fixes two problems with the original code:
There might still be some non-deterministic behaviour due to rounding error in reduction operations depending on the order of execution.