Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated documentation #55

Merged
merged 32 commits into from
Aug 28, 2024
Merged

Updated documentation #55

merged 32 commits into from
Aug 28, 2024

Conversation

VictorForouhar
Copy link
Collaborator

This PR is intended to address #54. This should explain:

  • How this version is different from Jiaxin's version
  • How to compile using cmake, which was not explained in the original wiki (It still recommends make, without running cmake)
  • What are the steps to run HBT, particularly for SWIFT snapshots.
  • Provide and update example configuration files for general and swift-based HBT+ analysis.
  • A script to submit in HPC systems like COSMA (?)

VictorForouhar and others added 30 commits August 10, 2024 20:06
@VictorForouhar
Remove outdated todo
44cdff2
@VictorForouhar
Added requirements and recommended compilation steps
73ff2bc
@VictorForouhar
Added some suggested versions for required dependencies.
7ea3030
@VictorForouhar
Added information on running
5ca4392
@VictorForouhar
Fix typo
73d1fb4
@VictorForouhar
Mention default values for HBT executable
8bd5d87
@VictorForouhar
Capitalised README
1443d1d
@VictorForouhar
Moved splitting scripts to their own subdirectory
2a96e02
@VictorForouhar
Added WIP scripts used to submit splitting + HBT jobs
f91d487
@VictorForouhar
Added slurm submission scripts
6e3ee67
@VictorForouhar
Changed values and paths to be more sensible
6001b45
@VictorForouhar
Added config template and a bash script to fill it in
5c177ae
@VictorForouhar
Renamed file
cf9b636
@VictorForouhar
Changed main scripts
385e792
@VictorForouhar
Removed unused paths
906da2c
@robjmcgibbon
Update pipeline scripts to output outside simulation directory
02920cb
@robjmcgibbon
Squash bug
bd0387f
@robjmcgibbon
Squash bug
5ffc2cd
@robjmcgibbon
Update job names
09475fd
@robjmcgibbon
Use timing.log to determine HBT snap
6f03a70
@robjmcgibbon
Squash bug
deaa8d8
@robjmcgibbon
Update permissions
1310eef
@VictorForouhar
Print when a snapshot is done + total time it took
2a078e4
@VictorForouhar
Fixed bug caused by confusion about snapshot subdirectories
7a2bd5c
@VictorForouhar
Comment setfacl due to permission issues
01d49c5
@VictorForouhar
Remove setfacl
d099a32
@VictorForouhar
Make start_halo_finding more general
b295d86
@VictorForouhar
Remove unnecessary module import form test
b43d45d
@VictorForouhar
Fixed time print in logs
78f4a1c
@VictorForouhar
Fixed bug with empty timing.log
07190e5
@robjmcgibbon robjmcgibbon marked this pull request as ready for review August 28, 2024 07:14
@VictorForouhar VictorForouhar merged commit 66eeb5b into master Aug 28, 2024
@VictorForouhar VictorForouhar deleted the docs branch August 28, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjmcgibbon robjmcgibbon robjmcgibbon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VictorForouhar @robjmcgibbon