-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: consistent
selector
parameters (#983)
### Summary of Changes - Name all parameters `selector` that select a subset of the columns of a `Table` by name or (later) by a `ColumnSelector`. - Parameters of `Table.join` and `Table.to_tabular_dataset` are deliberately unchanged, since I want users to always specify column names here explicitly. - Remove the ability to pass a lambda predicate to `select_columns`. - This was inconsistent with the other `selector` parameters. - It was also quite slow, since we sequentially looped over the columns. The upcoming `ColumnSelector`s will cover common cases and be more performant. - For all other cases, simply use `Table.to_columns`, a list comprehension, and `Table.from_columns`,
- Loading branch information
1 parent
2db9069
commit dc4640b
Showing
33 changed files
with
220 additions
and
253 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.