Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stabilize Column #981

Merged
merged 36 commits into from
Jan 14, 2025
Merged

feat: stabilize Column #981

merged 36 commits into from
Jan 14, 2025

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Jan 14, 2025

Closes partially #754
Closes partially #977

Summary of Changes

  • Improve documentation for all methods of Column.
  • Add the option to specify the column type when calling the constructor. If omitted, it is still inferred from the data.

Copy link
Contributor

github-actions bot commented Jan 14, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 74 0 0 1.86s
✅ PYTHON mypy 74 0 3.72s
✅ PYTHON ruff 74 0 0 0.3s
✅ REPOSITORY git_diff yes no 0.28s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 99.43182% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.04%. Comparing base (ca1ce3d) to head (e286ac6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/safeds/data/tabular/plotting/_table_plotter.py 98.80% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #981      +/-   ##
==========================================
+ Coverage   95.00%   95.04%   +0.03%     
==========================================
  Files         123      125       +2     
  Lines        7711     7725      +14     
==========================================
+ Hits         7326     7342      +16     
+ Misses        385      383       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann merged commit 38dc89c into main Jan 14, 2025
10 checks passed
@lars-reimann lars-reimann deleted the finalize_column branch January 14, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant