Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMATIC-208] fix slow test times #1566

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Conversation

andrewelamb
Copy link
Contributor

@andrewelamb andrewelamb commented Jan 8, 2025

  • Fixes SCHEMATIC-208
  • Removes test_create_table
  • Lowers test folders to copy in test manifest

@andrewelamb andrewelamb requested a review from a team as a code owner January 8, 2025 17:14
@thomasyu888 thomasyu888 changed the title SCHEMATIC 208 fix slow test times [SCHEMATIC-208] fix slow test times Jan 8, 2025
@BryanFauble
Copy link
Collaborator

BryanFauble commented Jan 8, 2025

I was hoping to be able to look at code coverage before/after the changes, but it seems that code coverage in sonarcloud broke in December:

https://sonarcloud.io/project/activity?from=2024-09-05T10%3A25%3A26%2B0000&graph=coverage&id=Sage-Bionetworks_schematic&to=2025-01-04T03%3A53%3A46%2B0000
image

If you have time while working on these changes getting code coverage working again would be amazing!

Code coverage works by passing an XML file to sonarcloud based on this github workflow code:

- name: Download coverage report
uses: actions/download-artifact@v4
if: steps.check_coverage_report.outputs.exists == 'true'
with:
name: coverage-report
- name: Check coverage.xml file existence
id: check_coverage_xml
uses: andstor/file-existence-action@v3
with:
files: "coverage.xml"
# This is a workaround described in https://community.sonarsource.com/t/sonar-on-github-actions-with-python-coverage-source-issue/36057
- name: Override Coverage Source Path for Sonar
if: steps.check_coverage_xml.outputs.files_exists == 'true'
run: sed -i "s/<source>\/home\/runner\/work\/schematic\/schematic\/schematic<\/source>/<source>\/github\/workspace\/schematic<\/source>/g" coverage.xml

Copy link
Collaborator

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I would like to see # of covered lines before/after the changes though (See my comment)

Copy link
Contributor

@GiaJordan GiaJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I know you mentioned also removing the parameterization from the remaining tests; does that need to be done in a later PR?

@thomasyu888
Copy link
Member

Looks good to me! I would like to see # of covered lines before/after the changes though (See my comment)

Upvoting this. Thanks everyone!

@linglp linglp self-requested a review January 8, 2025 20:23
Copy link
Contributor

@linglp linglp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too but also likes to see code coverage.

@andrewelamb
Copy link
Contributor Author

So somewhere around here, the Sonarcloud cation became depricated, and also stopped working. I'm goign to try updating to the suggested action and see if that works.

@andrewelamb andrewelamb merged commit 50f93d8 into develop Jan 13, 2025
8 checks passed
@andrewelamb andrewelamb deleted the SCHEMATIC-208-test-times branch January 13, 2025 16:02
@thomasyu888
Copy link
Member

🔥 see this chat for validation: https://sagebionetworks.slack.com/archives/C028KRF7ZA5/p1736529492842709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants