-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCHEMATIC-208] fix slow test times #1566
Conversation
I was hoping to be able to look at code coverage before/after the changes, but it seems that code coverage in sonarcloud broke in December: https://sonarcloud.io/project/activity?from=2024-09-05T10%3A25%3A26%2B0000&graph=coverage&id=Sage-Bionetworks_schematic&to=2025-01-04T03%3A53%3A46%2B0000 If you have time while working on these changes getting code coverage working again would be amazing! Code coverage works by passing an XML file to sonarcloud based on this github workflow code: schematic/.github/workflows/test.yml Lines 191 to 204 in 48da1c0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I would like to see # of covered lines before/after the changes though (See my comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I know you mentioned also removing the parameterization from the remaining tests; does that need to be done in a later PR?
Upvoting this. Thanks everyone! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too but also likes to see code coverage.
So somewhere around here, the Sonarcloud cation became depricated, and also stopped working. I'm goign to try updating to the suggested action and see if that works. |
Quality Gate passedIssues Measures |
🔥 see this chat for validation: https://sagebionetworks.slack.com/archives/C028KRF7ZA5/p1736529492842709 |
test_create_table