Skip to content

Commit

Permalink
fix(locale): remove hintString translation key
Browse files Browse the repository at this point in the history
the `hintString` translation key is no longer mandatory and has been removed. If consumers would
like to pass a hint string they can do so by passing the optional `inputHint` prop

BREAKING CHANGE: As the `hintString` translation key is public facing, its removal will mean a
type / compile error may be thrown in consumers TypeScript projects
  • Loading branch information
tomdavies73 authored and robinzigmond committed Oct 19, 2023
1 parent abfdf46 commit a814e14
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion src/locales/en-gb.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ const enGB: Locale = {
yes: () => "Yes",
},
characterCount: {
hintString: () => "Input contains a character counter",
tooManyCharacters: (count, formattedCount) =>
count === 1
? `${formattedCount} character too many`
Expand Down
1 change: 0 additions & 1 deletion src/locales/locale.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ interface Locale {
ariaLabel: () => string;
};
characterCount: {
hintString: () => string;
tooManyCharacters: (count: number, formattedCount: string) => string;
charactersLeft: (count: number, formattedCount: string) => string;
visuallyHiddenHint: (formattedCount: string) => string;
Expand Down
1 change: 0 additions & 1 deletion src/locales/pl-pl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ const plPL: Locale = {
yes: () => "Tak",
},
characterCount: {
hintString: () => "Pole zawiera licznik znaków",
tooManyCharacters: (count, formattedCount) =>
`Masz o ${formattedCount} ${PolishPlural(
"znak",
Expand Down

0 comments on commit a814e14

Please sign in to comment.