FE-6026 text editor validations #6274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 91bb986:
|
edleeks87
force-pushed
the
FE-6026-text-editor-validations
branch
from
bdb880b to
31f353a
Compare
edleeks87
force-pushed
the
FE-6026-text-editor-validations
branch
2 times, most recently
from
38de305 to
7ac7888
Compare
...onents/text-editor/__internal__/editor-validation-wrapper/editor-validation-wrapper.style.ts
Outdated
Show resolved
Hide resolved
edleeks87
force-pushed
the
FE-6026-text-editor-validations
branch
from
7ac7888 to
be55bd6
Compare
robinzigmond
approved these changes
Oct 10, 2023
DipperTheDan
approved these changes
Oct 10, 2023
stephenogorman
approved these changes
Oct 17, 2023
edleeks87
force-pushed
the
FE-6026-text-editor-validations
branch
from
be55bd6 to
91bb986
Compare
|
🎉 This PR is included in version 121.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Updates CharacterCount styles with tokens
Adds support for new validation and character count layout to TextEditor
Current behaviour
Character styles using pixel values instead of tokens
TextEditor does not support new validation or character count layout
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions
The following CodeSandbox is an example of the broken behaviour.
You can see the new behaviour by looking at the version in the comment by
codesandbox[bot].