-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:(Typography) add text-align prop and support span variant <FE-6204 & FE-6220> #6334
Conversation
baff024
to
c46b2f6
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 553d854:
|
c46b2f6
to
85809b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: we have some variant tests already in typography.cy.tsx
, where we check the variant is applied, font-size, line-height, font-weight, text-transform and text-decoration-line. It might be worth adding "span"
to these tests. We can do this by adding "span"
to VARIANT_TYPES
, getAs, getSize, getLineHeight, getWeight
functions etc. Could be a good shout to ensure span is added with other variants as a baseline.
1622ffd
to
1582c73
Compare
Added this now. |
Hi @nineteen88 , could you please add cypress tests for TextAlign prop? |
52cc415
to
d7af436
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: unrelated to these changes, but it might be worth us refactoring the cypress file in the future to remove these value lookups on lines 12-160. I feel this could be simplified quite a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I've spoken to @edleeks87 about this and we will do a refactor of the tests later. You're definitely correct.
d7af436
to
553d854
Compare
🎉 This PR is included in version 121.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Proposed behaviour
text-align
span
as a variantfixes #6331
Current behaviour
Currently there is no support for the above props and span variant
Checklist
d.ts
file added or updated if requiredQA
https://codesandbox.io/s/carbon-quickstart-forked-24w5sc