test(fieldset): playwright refactor #6366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 14b6397:
|
Parsium
reviewed
Oct 16, 2023
divyajindel
requested changes
Oct 19, 2023
| ["rgb(102, 132, 148)", "warning", false], | ||
| ["rgb(102, 132, 148)", "info", false], | ||
| ] as [string, string, boolean][]).forEach(([borderColor, type, bool]) => { | ||
| test(`should verify input border colour is ${borderColor} when validation is ${type} and boolean prop is ${bool}`, async ({ |
There was a problem hiding this comment.
Suggested change
| test(`should verify input border colour is ${borderColor} when validation is ${type} and boolean prop is ${bool}`, async ({ | |
| test(`should verify input border color is ${borderColor} when validation is ${type} and boolean prop is ${bool}`, async ({ |
| ["rgb(102, 132, 148)", "warning", false], | ||
| ["rgb(102, 132, 148)", "info", false], | ||
| ].forEach((borderColor, type, bool) => { | ||
| test(`should pass accessibility tests with input border colour ${borderColor} when validation is ${type} and boolean prop is ${bool}`, async ({ |
There was a problem hiding this comment.
Suggested change
| test(`should pass accessibility tests with input border colour ${borderColor} when validation is ${type} and boolean prop is ${bool}`, async ({ | |
| test(`should pass accessibility tests with input border color ${borderColor} when validation is ${type} and boolean prop is ${bool}`, async ({ |
Parsium
approved these changes
Oct 24, 2023
divyajindel
approved these changes
Oct 25, 2023
stephenogorman
force-pushed
the
pw_refactor_fieldset
branch
from
c2b394d to
14b6397
Compare
|
🎉 This PR is included in version 123.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Refactor Fieldset tests from Cypress to Playwright
Current behaviour
Tests are currently Cypress
Checklist
d.tsfile added or updated if requiredQA
Additional context
N/A
Testing instructions
Testing instructions
fieldset.pw.tsxfile passed*.pw.tsxfiles have regressed