Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): correct the width and height of icons inside buttons #6371

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

harpalsingh
Copy link
Member

@harpalsingh harpalsingh commented Oct 13, 2023

Proposed behaviour

Correct the icon sizes when used inside a button to 20px width and height.

Current behaviour

Icons inside button are currently using "space" as 16px width and height.

Visual to show changes

button-fix

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Cypress automation tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in CodeSandbox/storybook
  • Add new Cypress test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

n/a

Testing instructions

View Button story and view button with an icon, inspect to view size render.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 13, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0ea3b36:

Sandbox Source
carbon-quickstart Configuration
carbon-quickstart-typescript Configuration

@stephenogorman stephenogorman merged commit 42d1ad8 into master Nov 6, 2023
15 checks passed
@stephenogorman stephenogorman deleted the FE-6242 branch November 6, 2023 11:26
@carbonci
Copy link
Collaborator

carbonci commented Nov 6, 2023

🎉 This PR is included in version 123.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants