Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update text editor link preview story to prevent previews being added on focus #6387

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

edleeks87
Copy link
Contributor

Proposed behaviour

Preview should not be added on focus of editor

Current behaviour

New preview is added on focus of editor

2023-10-25 15 21 08

Checklist

  • Commits follow our style guide
  • Screenshots are included in the PR if useful
  • Storybook added or updated if required

QA

  • Tested in CodeSandbox/storybook
  • Add new Cypress test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

text-editor--with-link-previews story should be used for testing

The following CodeSandbox is an example of the broken behaviour.
You can see the new behaviour by looking at the version in the comment by codesandbox[bot].

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 25, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0999398:

Sandbox Source
carbon-quickstart Configuration
carbon-quickstart-typescript Configuration
carbon-quickstart PR

@DipperTheDan DipperTheDan marked this pull request as ready for review October 25, 2023 15:20
@DipperTheDan DipperTheDan requested a review from a team as a code owner October 25, 2023 15:20
@edleeks87 edleeks87 merged commit a54d91f into master Oct 26, 2023
@edleeks87 edleeks87 deleted the text-editor-link-prev-story branch October 26, 2023 17:10
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 123.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants