Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(confirm): make data tag props available on cancel and confirm buttons - FE-6251 #6388

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

DipperTheDan
Copy link
Contributor

@DipperTheDan DipperTheDan commented Oct 25, 2023

This enhancement makesdata-role and data-element tags available on the cancel and confirm buttons in this component

fixes #6374

Proposed behaviour

Makes the data tag props available to be used via two new props called cancelButtonDataProps and confirmButtonDataProps.

Current behaviour

Data tags cannot be used on either cancel or confirm buttons.

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Cypress automation tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in CodeSandbox/storybook
  • Add new Cypress test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

N/A

Testing instructions

  • Should be able to pass custom data-role and data-element props to the cancel or confirm buttons. Confirm with Custom Data Tags example should demonstrate this.
  • There should be no other regressions with functionality or styling with this component.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 25, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c995a22:

Sandbox Source
carbon-quickstart Configuration
carbon-quickstart-typescript Configuration

@tomdavies73 tomdavies73 self-requested a review October 25, 2023 15:32
…ttons

This enhancement makes `data-component`, `data-role` and `data-element` tags available on the cancel
and confirm buttons in this component

fixes #6374
@DipperTheDan DipperTheDan force-pushed the FE-6251_data-props-confirms-buttons branch from 4bc7e01 to 2c69101 Compare October 25, 2023 16:00
@edleeks87 edleeks87 marked this pull request as ready for review October 26, 2023 16:11
@edleeks87 edleeks87 requested review from a team as code owners October 26, 2023 16:11
@DipperTheDan DipperTheDan merged commit 8935a38 into master Oct 30, 2023
15 checks passed
@DipperTheDan DipperTheDan deleted the FE-6251_data-props-confirms-buttons branch October 30, 2023 16:59
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 123.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

support data- props on Confirm's buttons
5 participants