fix(popover-container): ensure component is accessible by screen readers #7153
+438
−258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds hasFullWidth flag to enable fullWidth Button behaviour and remove the default 100% width on the component.
…yling Fixes styling issues on a Form with stickyFooter within a PopoverContainer, adds border-radius and overflow styling so that form content can render as a scrollable container. Also prevents tabbing onto the form element.
…ally Exposes `focusButton` method to allow consumers to programmatically focus on the open button using ref.
| @@ -86,7 +86,7 @@ You can easily use many different components to create your own composition. | |||
| ### Filter component | |||
|
|
|||
| If you want to use the `PopoverContainer` to create for example `Filter` component. | |||
| You can do it easly in this way: | |||
| You can do it easily in this way: | |||
There was a problem hiding this comment.
praise(non-blocking): Well spotted.
| @@ -391,15 +389,15 @@ describe("opening the popup", () => { | |||
| }, | |||
| ); | |||
|
|
|||
| it("open button still has focus after popup is opened", async () => { | |||
| it("focus moves to dialog when popup is opened", async () => { | |||
There was a problem hiding this comment.
nitpick/suggestion: Just changing a word around to make the test description make grammatical sense.
Suggested change
| it("focus moves to dialog when popup is opened", async () => { | |
| it("moves focus to dialog when popup is opened", async () => { |
The component renders the popup within a Portal due to potential cascading styles when placed within a MenuItem. To ensure the popup is accessible by screen readers, the dialog will now gain focus when opened. fix #7133
DipperTheDan
approved these changes
Jan 15, 2025
damienrobson-sage
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7133
Proposed behaviour
hasFullWidthprop to enable fullWidth Button behaviour optionally.focusButtonmethod to enable consumers to programatically focus the open button.Current behaviour
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions