fix(search): search button has a default aria label

[mihai-albu-sage]

fixes: #7147

Proposed behaviour

When a button includes an aria-label attribute, screen readers prioritize the aria-label text over any visible content inside the button. This means the aria-label effectively replaces the visible text for accessibility purposes. If no aria-label attribute is present, it defaults to reading the button's visible text or any accessible content within it.

With this in mind, I’ve removed the default value of "search button" for the searchButtonAriaLabel prop and opted to use the button’s visible text instead.

This approach ensures that, in the absence of a specified value for searchButtonAriaLabel, the screen reader will read the button text by default. However, if a more explicit description is required, developers can set the searchButtonAriaLabel prop, and the screen reader will prioritize that instead.

Current behaviour

Currently if we do not provide a value for searchButtonAriaLabel the screen readers will read out the default value of search button instead of the button's text.

Checklist

• Commits follow our style guide
• Related issues linked in commit messages if required
• Screenshots are included in the PR if useful
• All themes are supported if required
• Unit tests added or updated if required
• Playwright automation tests added or updated if required
• Storybook added or updated if required
• Translations added or updated (including creating or amending translation keys table in storybook) if required
• Typescript d.ts file added or updated if required
• Related docs have been updated if required

QA

• Tested in provided StackBlitz sandbox/Storybook
• Add new Playwright test coverage if required
• Carbon implementation matches Design System/designs
• UI Tests GitHub check reviewed if required

Additional context

Testing instructions

[carbonci]

🎉 This PR is included in version 146.4.7 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀