fix(popover-container): prevent DatePicker from rendering behind the popover #7155
+142
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…popover Fixes issue where a Date input's date-picker popup would render behind a PopoverContainer's popup. fix #7137
| @@ -32,7 +32,7 @@ const PopoverContainerContentStyle = styled.div<PopoverContainerContentStyleProp | |||
| box-shadow: var(--boxShadow100); | |||
| min-width: 300px; | |||
| position: absolute; | |||
| z-index: ${({ theme }) => theme.zIndex.popover}; | |||
| z-index: 2000; | |||
There was a problem hiding this comment.
suggestion(non-blocking): Given the theme already contains a zIndex value for popover, is it not worth updating that instead and leaving this as it was? Absolutely fine as it is, BTW - just a passing thought.
There was a problem hiding this comment.
I'm hesitant to change the theme value since its being used elsewhere, could consider only changing the date-picker popup to match this one instead of updating both, happy to see what the other reviewers thinks
damienrobson-sage
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7137
Proposed behaviour
date-picker renders above a PopoverContainer's popover.
Current behaviour
date-picker renders behind a PopoverContainer's popover.
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions