FE-6858 - update date-fns from ^2.30.0 to ^4.10.0 #7156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main concern with my current implementation is that <DayPicker has a property locale that accepts a date-fns localize type. weekdaysLong and weekdaysShort are now not accepted properties. I did not know what to do for this scenario, so I removed the code entirely. However, I suspect that's not the correct behaviour. I would appreciate guidance for how to proceed.
quinnturner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7004
Proposed behaviour
Updates date-fns
Current behaviour
Checklist
d.tsfile added or updated if requiredQA
Additional context
The main concern with my current implementation is that
<DayPickerhas a property locale that accepts adate-fnslocalize type.weekdaysLongandweekdaysShortare now not accepted properties.I did not know what to do in this scenario, so I removed the code entirely. However, I suspect that's not the correct behaviour.
I would appreciate guidance on how to proceed.
Testing instructions