Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant type cast #120

Merged
merged 5 commits into from
May 26, 2024
Merged

Conversation

janus
Copy link
Member

@janus janus commented May 9, 2024

Remove redundant type casts and clean up code.

@janus janus requested a review from jbampton as a code owner May 9, 2024 20:12
Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have duplicate work in this PR which includes the work from your first PR.

PRs should be self contained and only focus on one thing or topic.

Please remove b.sh from this PR.

@janus janus force-pushed the RemoveRedundantTypeCast branch from 6c2a32f to 0122d6b Compare May 11, 2024 22:22
@janus
Copy link
Member Author

janus commented May 11, 2024

You have duplicate work in this PR which includes the work from your first PR.

PRs should be self contained and only focus on one thing or topic.

Please remove b.sh from this PR.

Done. Thanks for pointing that out.

@jbampton jbampton requested a review from anufdo May 12, 2024 11:06
@jbampton jbampton closed this May 25, 2024
@jbampton jbampton reopened this May 25, 2024
@erfangnu
Copy link
Member

it's good to have _t at end of struct names

@erfangnu erfangnu merged commit ab8408c into SalamLang:main May 26, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants