Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run shell format; shfmt -w -l #885

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Run shell format; shfmt -w -l #885

merged 1 commit into from
Jan 9, 2025

Conversation

jbampton
Copy link
Member

@jbampton jbampton commented Jan 9, 2025

@jbampton jbampton self-assigned this Jan 9, 2025
@jbampton jbampton requested a review from BaseMax as a code owner January 9, 2025 20:29
@BaseMax
Copy link
Member

BaseMax commented Jan 9, 2025

You need to do this format process inside pre-commit or git hook way. @jbampton

BaseMax
BaseMax approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@BaseMax BaseMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbampton
Copy link
Member Author

jbampton commented Jan 9, 2025

You need to do this format process inside pre-commit or git hook way. @jbampton

Perhaps:

https://github.com/scop/pre-commit-shfmt

https://github.com/un-ts/prettier/tree/master/packages/sh

@BaseMax
Copy link
Member

BaseMax commented Jan 9, 2025

Yes please, thanks.

@BaseMax BaseMax merged commit e04379a into SalamLang:main Jan 9, 2025
13 of 15 checks passed
@jbampton jbampton mentioned this pull request Jan 25, 2025
Open
@jbampton jbampton deleted the shell-format branch January 25, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BaseMax BaseMax BaseMax approved these changes

Assignees

@jbampton jbampton

Labels
code style scripts shell testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbampton @BaseMax