Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W-14308598 set batch default Values for GAU Allocation fields #7252

Conversation

salesforce-suyash-more
Copy link
Contributor

Critical Changes

Changes

Issues Closed

Community Ideas Delivered

Features Intended for Future Release

Features for Elevate Customers

New Metadata

Deleted Metadata

…Api-Name

Populate Batch Defaults field of DataImportBatch with keys as field labels instead of field names.
Set the batch-defaults field values to `undefined` to prevent null and blank values in form elements after updating batch-defaults.
Copy link
Contributor

@lparrott lparrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good! Will this have any effect on existing Templates?

@salesforce-suyash-more
Copy link
Contributor Author

@lparrott, this will not affect existing templates since we are only modifying how the batch-defaults JSON object is populated.

@lparrott lparrott self-requested a review October 11, 2024 20:54
@lparrott
Copy link
Contributor

@salesforce-suyash-more looks like there was a test failure, mind taking a look? Doesn't look related to your change though...

@salesforce-suyash-more
Copy link
Contributor Author

@lparrott, I have rebuilt the 'Feature Test' check, and it has passed all tests.

@lparrott lparrott merged commit a0357c0 into feature/254 Oct 14, 2024
7 of 12 checks passed
@lparrott lparrott deleted the feature/254__W-14308598-set-defaults-for-GAU-Allocation-fields-in-gift-entry branch October 14, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants