Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 254 #677

Merged
merged 20 commits into from
Nov 22, 2024
Merged

Feature 254 #677

merged 20 commits into from
Nov 22, 2024

Conversation

jjbennett
Copy link
Contributor

@jjbennett jjbennett commented Jul 26, 2024

Critical Changes

Changes

Issues Closed

New Metadata

Deleted Metadata

Definition of Done

Refer to Asteroids DoD document to see any additional details for the items below

  • Any net new LWC work has Sa11y tests & 50% or above lines JEST test coverage
  • CRUD/FLS is enforced in Apex
  • Permission sets are updated to account for CRUD|FLS|Tab|Classes
  • Field sets are updated to account for new fields
  • UX approval or UX not necessary
  • Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name (Reorganize code; use custom iterator #303)
  • All acceptance criteria have been met
    • Developer
    • Code Reviewer
    • QA
  • PR contains draft release notes
  • QE story level testing completed

Unaggregated Pull Requests

  • Switch install security to admin only [PR678]
  • Remove order by and filter by Contact name. [PR680]
  • Move to bulk save. [PR681]

@jjbennett jjbennett marked this pull request as draft July 26, 2024 13:14
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Jennifer Bennett <j***@j***.i***.s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Jennifer Bennett <j***@j***.i***.s***.com> jjbennett <j***@j***.i***.s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

@jjbennett jjbennett marked this pull request as ready for review November 21, 2024 19:21
@AndersonTarren AndersonTarren self-requested a review November 21, 2024 19:27
@AndersonTarren AndersonTarren merged commit b67c6f8 into main Nov 22, 2024
11 of 16 checks passed
@AndersonTarren AndersonTarren deleted the feature/254 branch November 22, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants