Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 custom code #13

Merged
merged 6 commits into from
Jul 1, 2024
Merged

V1 custom code #13

merged 6 commits into from
Jul 1, 2024

Conversation

bpapillon
Copy link
Collaborator

@bpapillon bpapillon commented Jun 17, 2024

This pull request implements Schematic V1 functionality for Schematic's C# library; V1 adds the following custom functionality:

  • Configurable in-memory caching for flag check evaluations (users should get an in-memory cache for flag check results by default, which they can disable, configure its TTL or max size, or even bring their own cache implementation)
  • Event buffering (i.e., track and identify events can be submitted via a non-blocking top-level function, and will be sent in batches behind the scenes)
  • Offline mode (to support local development environments without a Schematic API key, CI testing environments, etc)

@bpapillon bpapillon self-assigned this Jun 17, 2024
@bpapillon bpapillon marked this pull request as draft June 17, 2024 20:24
@bpapillon bpapillon force-pushed the v1 branch 12 times, most recently from a65d915 to 6e951a4 Compare June 19, 2024 02:07
@bpapillon
Copy link
Collaborator Author

bpapillon commented Jun 28, 2024

@bpapillon TODO:

  • add github action for tests
  • confirm dependency change with Fern

@nasimsaleh TODO:

  • small change (inline comment) for cache key
  • update README to reflect interface changes (eg changes to cache, TTL type)

@bpapillon bpapillon marked this pull request as ready for review July 1, 2024 03:18
@bpapillon bpapillon merged commit 59823f5 into main Jul 1, 2024
3 checks passed
@bpapillon bpapillon deleted the v1 branch July 1, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants