Refactoring GMGPolar #65
Conversation
julianlitz
force-pushed
the
Refactoring2024
branch
from
d55a6c9 to
e3c8bc7
Compare
julianlitz
force-pushed
the
Refactoring2024
branch
from
1567c79 to
842c9bb
Compare
| #include <array> | ||
| #include <initializer_list> | ||
|
|
||
| enum class StencilType |
There was a problem hiding this comment.
StencilType may be a bit misleading name here. ( neighbour type ? )
| BottomRight, | ||
| }; | ||
|
|
||
| class Stencil |
There was a problem hiding this comment.
Stencil is again misleading. When I think of stencil values I would assume they store something like [ 0 1 0 ; 1 -4 1; 0 1 0 ]
There was a problem hiding this comment.
May be add a comment that this Stencil class helps when building sparse matrices
|
|
||
| class LevelCache; | ||
|
|
||
| class Level |
There was a problem hiding this comment.
Consider renaming this class and use level only for indicating multigrid level
| const DensityProfileCoefficients& density_profile_coefficients, | ||
| const bool DirBC_Interior, const int num_omp_threads, | ||
| const StencilDistributionMethod stencil_distribution_method); | ||
| void directSolveInPlace(Vector<double>& x) const; |
There was a problem hiding this comment.
Does InPlace imply you overwrite the RHS with the solution? (maybe add a comment)
| if (row == column) \ | ||
| center_matrix.main_diagonal(row) += value; \ | ||
| else if (row == column - 1) \ | ||
| center_matrix.sub_diagonal(row) += value; \ | ||
| else if (row == 0 && column == center_matrix.columns() - 1) \ | ||
| center_matrix.cyclic_corner_element() += value; \ |
There was a problem hiding this comment.
You can use an inline function here instead of repeating this pattern (ex. update(matrix, value, row, col))
| const int center_index = i_theta; \ | ||
| const int left_index = i_theta; \ | ||
| const int right_index = (i_r + 1 == numberSmootherCircles) ? 0 : i_theta; \ | ||
| const int bottom_index = i_theta_M1; \ | ||
| const int top_index = i_theta_P1; \ |
There was a problem hiding this comment.
Add a comment about these indices (row inside their local tridiagonal matrix as you explained)
| else { | ||
| auto& solverMatrix = circle_tridiagonal_solver_[circle_Asc_index]; | ||
|
|
||
| solverMatrix = SymmetricTridiagonalSolver<double>(num_circle_nodes); | ||
| solverMatrix.is_cyclic(true); | ||
| solverMatrix.cyclic_corner_element() = 0.0; | ||
|
|
||
| for (int i = 0; i < num_circle_nodes; i++) { | ||
| solverMatrix.main_diagonal(i) = 0.0; | ||
| if (i < num_circle_nodes - 1) { | ||
| solverMatrix.sub_diagonal(i) = 0.0; | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
May be have a different function for zero initializations
There was a problem hiding this comment.
Comments/illustrations explaining node coloring should be very helpful
There was a problem hiding this comment.
Using GLOB can cause issues when changing or adding files. CMake files are usually recursive (ex. https://gitlab.com/CLIUtils/modern-cmake/-/tree/master/examples/extended-project)
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
[ ] The following questions are addressed in the documentation (if need be):
Developers (what did you do?, how can it be maintained?)
For users (how to use your work?)
For admins (how to install and configure your work?)
For documentation: Please write or update the Readme in the current working directory!
Checks by code reviewer(s):