Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1121 LCT paper #1164

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

1121 LCT paper #1164

wants to merge 14 commits into from

Conversation

lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Dec 16, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Added simulation scripts, shell scripts (to get all the data with one command), and plot scripts used to create the figures of the LCT paper.
  • I validated that the figures in the paper look the same as the outputs using these files.

If need be, add additional information and what the reviewer should look out for in particular:

  • Functionality that affect the model are also included in PR 1174 Use DIVI data to scale initial values for LCT model #1175 . If the PR is reviewed and merged, this PR only consists of the simulation and plot scripts for the 2024 LCT paper.
  • I tried to document what is happening really detailed, such that my work can be easily continued. If I missed out anything, please comment.

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1121

@lenaploetzke lenaploetzke added the model::lct Models using the linear chain trick label Dec 16, 2024
@lenaploetzke lenaploetzke self-assigned this Dec 16, 2024
@lenaploetzke lenaploetzke linked an issue Dec 16, 2024 that may be closed by this pull request
@mknaranja mknaranja changed the title 1121 lct paper 1121 LCT paper Dec 16, 2024
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.98%. Comparing base (0c4965a) to head (7d1b4a8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1164      +/-   ##
==========================================
+ Coverage   96.97%   96.98%   +0.01%     
==========================================
  Files         148      148              
  Lines       13718    13779      +61     
==========================================
+ Hits        13303    13364      +61     
  Misses        415      415              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model::lct Models using the linear chain trick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simulation for age-resolved LCT model
1 participant