Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1176 Bindings for Secirvvs specific io functions #1180

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

HenrZu
Copy link
Contributor

@HenrZu HenrZu commented Jan 10, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Write Bindings for the functions set_population_data, set_confirmed_cases_data, set_divi_data and set_vaccination_data from the parameters_io.h file.

If need be, add additional information and what the reviewer should look out for in particular:

  • As discussed. Due to our structure, we dont have access to the cpp/test/data dir in the python tests. Therefore, in order to test the binded functions, it would be necessary to upload data, which is >200kb.
  • It was well tested locally. Therefore, we decided to merge without unit tests here.

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@HenrZu HenrZu changed the title 1176 Binding Secirvvs specific io functions 1176 Bindings for Secirvvs specific io functions Jan 10, 2025
@HenrZu HenrZu linked an issue Jan 10, 2025 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.98%. Comparing base (0c4965a) to head (3e779e1).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1180      +/-   ##
==========================================
+ Coverage   96.97%   96.98%   +0.01%     
==========================================
  Files         148      148              
  Lines       13718    13783      +65     
==========================================
+ Hits        13303    13368      +65     
  Misses        415      415              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model specific IO functions are not usable from python
1 participant