Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1196 Add missing comment for pop in get_derivatives() #1197

Merged

Conversation

kilianvolmer
Copy link
Contributor

@kilianvolmer kilianvolmer commented Jan 21, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Added comment for pop in the get_derivatives definition

If need be, add additional information and what the reviewer should look out for in particular:

Closes #1196

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@kilianvolmer kilianvolmer requested a review from reneSchm January 21, 2025 12:02
@kilianvolmer kilianvolmer self-assigned this Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.98%. Comparing base (bae6709) to head (53b5c4b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cpp/memilio/compartments/compartmentalmodel.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1197   +/-   ##
=======================================
  Coverage   96.98%   96.98%           
=======================================
  Files         148      148           
  Lines       13782    13782           
=======================================
  Hits        13367    13367           
  Misses        415      415           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@reneSchm reneSchm changed the title CHG: Add missing comment for pop in get_derivatives() 1196 Add missing comment for pop in get_derivatives() Jan 21, 2025
@reneSchm reneSchm merged commit a06a573 into main Jan 21, 2025
57 of 58 checks passed
@reneSchm reneSchm deleted the 1196-inconsistency-in-comments-for-get_derivatives-function branch January 21, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency in comments for get_derivatives function
2 participants