-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
636 make python serialization usable again #761
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #761 +/- ##
=======================================
Coverage 96.42% 96.42%
=======================================
Files 130 130
Lines 10364 10364
=======================================
Hits 9994 9994
Misses 370 370 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the general design, but have a few concerns about the implementation. I also don't understand some of the choices of TryPickling/ForcePickling/NoPickling, but I only added comments for some cases. Maybe try to explain your general reasoning there.
Changes and Information
Please briefly list the changes made, additional Information and what the Reviewer should look out for:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #636