Fix bug in deletion, better validation error handling

[NolanTrem]

Important

Fixes deletion bug and enhances validation error handling in management_router.py and management_service.py, including UUID validation and documentation correction.

• Behavior:
  • Fixes bug in delete_app() in management_router.py by adding JSON validation for filters and ensuring they are a dictionary.
  • Updates error handling in delete_app() to raise R2RException with status 422 for invalid JSON and filter formats.
  • Changes status code from 400 to 422 for invalid document ID format in download_file_app() in management_router.py.
• Validation:
  • Adds validate_uuid() function in base_utils.py to validate UUID strings.
  • Integrates validate_uuid() in delete() in management_service.py to check UUIDs in filters.
• Documentation:
  • Corrects command in graphrag.mdx from r2r serve --docker --config-name=full to r2r serve --full --docker --config-name=full.

^{This description was created by for 8520719. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 8520719 in 20 seconds

More details

• Looked at 247 lines of code in 9 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. py/core/main/api/management_router.py:309

• Draft comment:
  Changing the status code from 400 to 422 for invalid document ID format is appropriate as 422 is more specific for unprocessable entity errors.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The change from status_code=400 to status_code=422 for invalid document ID format is appropriate as 422 is more specific for unprocessable entity errors, which fits the context of invalid input format.

2. py/core/base/utils/__init__.py:20

• Draft comment:
  The addition of validate_uuid to __all__ and imports in multiple __init__.py files is a good practice for making this utility function widely available across modules.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The validate_uuid function is being added to multiple __init__.py files, which suggests it is being made available for use across different modules. This is a good practice for utility functions that are widely used.

3. py/core/main/services/management_service.py:278

• Draft comment:
  The validate_filters function is a good addition for ensuring only allowed filters are processed and for validating UUIDs, enhancing input validation.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The validate_filters function in delete method ensures that only allowed filters are processed and validates UUIDs, which is a good practice for input validation.

Workflow ID: wflow_MJR7fQLERpE9HlAZ

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
yc_demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 10, 2024 10:47pm
yc-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 10, 2024 10:47pm